OCPBUGS-13547: [OCPCLOUD-2034] Update feature gate observation to use featuregateaccess #249
Conversation
openshift-ci
bot
added
the
do-not-merge/hold
| recorder, | ||
| ) | ||
|
|
||
| featureGateAccessor.SetChangeHandler(func(featureChange featuregates.FeatureChange) { |
There was a problem hiding this comment.
We've been watching and reacting to the feature gate changes since we started this operator, if it couldn't handle the change (eg from nothing to TPNU) then we would have hit issues before no?
|
/hold Since this comes so early in the bootstrap process, it relies on the install time feature gate rendering, will need to merge the installer PR before we can merge |
JoelSpeed
force-pushed
the
update-feature-gate-observation
branch
2 times, most recently
from
28f6af3 to
2f48abb
Compare
JoelSpeed
force-pushed
the
update-feature-gate-observation
branch
from
2f48abb to
c135301
Compare
|
/hold cancel I believe prior issues are now resolved |
openshift-ci
bot
removed
the
do-not-merge/hold
JoelSpeed
changed the title
openshift-ci-robot
added
jira/valid-reference
|
@JoelSpeed: This pull request references Jira Issue OCPBUGS-13547, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/valid-bug
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
elmiko
left a comment
elmiko
left a comment
There was a problem hiding this comment.
i'm not super familiar with the featuregate access stuff, but this pr makes sense to me
/lgtm
|
/retest |
|
@JoelSpeed: Jira Issue OCPBUGS-13547: Some pull requests linked via external trackers have merged: The following pull requests linked via external trackers have not merged:
These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with Jira Issue OCPBUGS-13547 has not been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@JoelSpeed: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
5 participants
This updates the way we look at feature gates to use the new featuregateaccess interface from library-go. This means the decision is now made centrally and not by vendored code in each repository, which will greatly improve the UX for promoting a feature in this repo.
/hold for library-go pin